From 17325f565e7b474180edbef1281c4aa3a650c170 Mon Sep 17 00:00:00 2001 From: Jeppe Bundgaard Date: Thu, 29 Jan 2026 20:31:05 +0100 Subject: [PATCH] Update Slack notification logic and refine `COUNT_ONLY` summary rendering - Swap `send_message` with `send_webhook_message` to fix departmental Slack notification issues. - Adjust `COUNT_ONLY` in `renderDanishPeriodSummary` to exclude targets for raw count-focused alerts. --- .../modules/goals/services/goals_progress_alert_renderer.php | 3 ++- services/nginx/app/routes/departmentGoalsRoute.php | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/services/nginx/app/modules/goals/services/goals_progress_alert_renderer.php b/services/nginx/app/modules/goals/services/goals_progress_alert_renderer.php index d96309c2..c4be6117 100644 --- a/services/nginx/app/modules/goals/services/goals_progress_alert_renderer.php +++ b/services/nginx/app/modules/goals/services/goals_progress_alert_renderer.php @@ -48,7 +48,8 @@ class goals_progress_alert_renderer $body = match ($criteria->progress_alert_progress_type) { // New DK multi-line formats for COUNT_ONLY and ALL - PType::COUNT_ONLY => self::renderDanishPeriodSummary($criteria, includeTargets: true, + // COUNT_ONLY should show raw counts only (no targets/percent) + PType::COUNT_ONLY => self::renderDanishPeriodSummary($criteria, includeTargets: false, header: [ $deptNames !== '' ? "$deptLabel: $deptNames" : null, $customerNames !== '' ? "$customerLabel: $customerNames" : null, diff --git a/services/nginx/app/routes/departmentGoalsRoute.php b/services/nginx/app/routes/departmentGoalsRoute.php index b7c05c32..bfebde0c 100644 --- a/services/nginx/app/routes/departmentGoalsRoute.php +++ b/services/nginx/app/routes/departmentGoalsRoute.php @@ -350,8 +350,8 @@ class departmentGoalsRoute if (empty($slackWebhook)) { continue; } - (new Slack())->send_message((string)goals_progress_alert_renderer::render($criteria, $dept), (string)$dept->name->value()); - //(new Slack())->send_webhook_message((string)$message, (string)$dept->slack_webhook->value()); TODO: remove the above ^ + //(new Slack())->send_message((string)goals_progress_alert_renderer::render($criteria, $dept), (string)$dept->name->value()); + (new Slack())->send_webhook_message((string)goals_progress_alert_renderer::render($criteria, $dept), (string)$dept->slack_webhook->value()); } } else { (new Slack())->send_message($message);