copenhagentruckwash/api
1
0
Fork 0
Code Issues Pull Requests 1 Actions 2 Packages Projects Releases Wiki Activity

Resolve backend Qodana critical and high findings (#314)

Browse Source 
Resolve recommended-profile Critical and High findings, retain narrow analyzer exceptions, and update the edge-broker WebSocket dependency to a non-vulnerable release.
This commit is contained in:
Jeppe B
2026-07-17 05:44:16 +02:00
committed by GitHub
parent 6566027746
commit 2a6a86c9c3
108 changed files with 234 additions and 1283 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/nginx/app/routes/exampleRoute.php
+3 -123
View File
@@ -28,136 +28,17 @@ class exampleRoute
});
$this->get('/tmp-send-email', function () {
global $response;
$response->error(['message' => 'This route is deprecated.']);
$emailAddress = "my@truckwash.dk";
$customer_name = "John Doe";
/**
* Tillykke med din nye kredit konto!
*
* Du kan nu vaske i alle vores afdelinger.
* Vedhæftet finder du en liste over vores afdelinger, som kan viderebringes til dine chauffører.
*
* Vi har oprettet en kredit konto til dig, med følgende informationer:
*
* Virksomhed: AT Kloakservice ApS
* Tlf: 77302200
* CVR: 40650717
*/
$email = new email();
$email->sendWelcomeEmailToCustomer($customer_number = 43632122, $emailAddress);
$response->success(['message' => 'This route is deprecated.']);
global $response;
$response->error(['message' => 'This route is deprecated.']);
});
$this->get('/tmp-washes-in-time', function () {
global $response;
$response->error(['message' => 'This route is deprecated.']);
$date_from = date('2026-01-01 00:00:00');
$date_to = date('2026-01-31 23:59:59');
// Set the hours on the date range to be from 17:00-23:59
$daily_start_time = '17:00:00';
$daily_end_time = '23:59:59';
// Loop through each day in the date range, and get the washes that were done in the time range
$washes = [];
$current_date = $date_from;
while (strtotime($current_date) <= strtotime($date_to)) {
$daily_start = date('Y-m-d', strtotime($current_date)) . ' ' . $daily_start_time;
$daily_end = date('Y-m-d', strtotime($current_date)) . ' ' . $daily_end_time;
$daily_washes = (new orders_o())->getWashesInTimeRange($daily_start, $daily_end, ['department_id' => 7]);
$washes = array_merge($washes, $daily_washes);
$current_date = date('Y-m-d H:i:s', strtotime($current_date . ' +1 day'));
}
$wash_arrays = array_map(function ($wash) {
return $wash->asArray();
}, $washes);
// Create a CSV file from the washes $csv = "Order ID,Customer ID,Department ID,Created At\n";
foreach ($wash_arrays as $wash) {
$csv .= "{$wash['id']},{$wash['customer_id']},{$wash['department_id']},{$wash['created_at']}\n";
}
// Output the CSV file
header('Content-Type: text/csv');
header('Content-Disposition: attachment; filename="washes_in_time_range.csv"');
echo $csv;
exit;
});
$this->get('/tmp-customer-list-overcharged', function () {
global $response;
$response->error(['message' => 'This route is deprecated.']);
/**
* Steps:
* 1. Get a list of all collected order invoices in january
* 2. Extract the customers, and make sure they haven't been charged more than once for product ID: 78.
* 3. Get a list of the amount of times, at what price and for what order IDs they have been charged.
* 4. If they have been charged more than once, add them to a list of overcharged customers.
* 5. Return the list of overcharged customers.
*/
// Step 1: Get a list of all collected order invoices in january
$invoices = [];
$product = (new products_o())->select(78);
$all_invoices = (new collected_order_invoices_o())->getObjectsWhereClause("closed_at BETWEEN '2026-01-31 00:00:00' AND '2026-02-01 23:59:59'");
// Filter out empty invoices
foreach ($all_invoices as $invoice) {
if ($invoice->isEmpty()) {
continue;
}
$invoices[] = $invoice;
}
// Get all orders related to the invoices
$overcharged_customers = [];
$order_ids = (new orders_o())->getFieldsWhereIn([
'deleted_at' => null,
'invoice_collection_id' => array_map(function ($invoice) {
return $invoice->id;
}, $invoices)],
['id', 'customer_id']);
$order_id_to_customer_id = array_column($order_ids, 'customer_id', 'id');
$order_ids = array_map(function ($order) {
return (int)$order['id'];
}, $order_ids);
// Get all the products in the orders
$order_items = (new order_items_o())->getFieldsWhereIn(['order_id' => $order_ids, 'product_id' => [$product->id], 'deleted_at' => null], ['price', 'quantity', 'order_id', 'id']);
// Define the customers => items map
$customer_items_map = [];
foreach ($order_items as $order_item) {
$customer_items_map[(string)$order_id_to_customer_id[(string)$order_item['order_id']]][] = $order_item;
}
// Ignore the first item for each customer (as that is correct)
foreach ($customer_items_map as $customer_id => $items) {
array_shift($customer_items_map[$customer_id]);
}
// Create a total per customer number of items and price map
foreach ($customer_items_map as $customer_id => $items) {
$total_quantity = 0;
$total_price = 0.0;
foreach ($items as $item) {
$total_quantity += (int)$item['quantity'];
$total_price += (float)$item['price'] * (int)$item['quantity'];
}
// If the total quantity is more than 1, add to overcharged customers
if ($total_quantity > 1) {
$overcharged_customers[$customer_id] = [
'total_quantity' => $total_quantity,
'total_price' => $total_price,
'items' => $items,
];
}
}
// Format message
foreach ($overcharged_customers as $customer_id => $data) {
$customer = (new users_o())->getUserByCustomerNumber((int)$customer_id);
$message = "Customer number: {$customer->customer_number->value()} - x{$data['total_quantity']} items for a total of {$data['total_price']} DKK\n";
//$message .= "Items:\n";
foreach ($data['items'] as $item) {
//$message .= "- Order Item ID: {$item['id']}, Order ID: {$item['order_id']}, Price: {$item['price']}, Quantity: {$item['quantity']}\n";
}
echo $message . "\n";
}
$response->success(['message' => 'Customer list overcharged', 'inv_count' => count($invoices), 'ord_count' => count($order_ids), 'order_ids' => $order_ids, 'order_items' => count($order_items), 'customer_items_map' => $customer_items_map, 'overcharged_customers' => $overcharged_customers]);
});
$this->get('/debug', function () {
global $response;
//$response->success(['message' => 'Debugging route!']);
@@ -171,7 +52,6 @@ class exampleRoute
$machine_1->setup();
$machine_1->servePicture();
exit;
$response->success(['message' => 'Debugging route!', 'base64_image' => $machine_1->exportAsBase64()]);
});
}
}
}