Refactor input value handling and improve validation in ObjectsGlobal component
This commit is contained in:
@@ -718,7 +718,7 @@ class departments_o extends db
|
||||
* @return null|array
|
||||
* @throws Exception
|
||||
*/
|
||||
public function sendSlackInternalStatisticNotification(string $date_start, string $date_end, array $department_ids, array $product_ids = [
|
||||
public function sendSlackInternalStatisticNotification(string $date_start, string $date_end, array $department_ids = [], array $product_ids = [
|
||||
25,
|
||||
[23, 24], // Used to merge two products into one percentage (Spot Free)
|
||||
22,
|
||||
@@ -727,6 +727,11 @@ class departments_o extends db
|
||||
26
|
||||
], bool $return_as_array = false): null|array
|
||||
{
|
||||
$slack = new slack();
|
||||
if (empty($department_ids)) {
|
||||
$department_ids = $slack->get_internal_department_ids();
|
||||
}
|
||||
|
||||
if (empty($department_ids)) {
|
||||
throw new Exception('No department ids provided for the Slack internal statistic notification.');
|
||||
}
|
||||
@@ -847,9 +852,11 @@ class departments_o extends db
|
||||
$array_of_results['daily_management'][] = $tmp;
|
||||
|
||||
// Send the message to the internal Slack webhook
|
||||
$slack = new slack();
|
||||
if (!$return_as_array) {
|
||||
$slack->send_webhook_message($tmp, (new departments_o())->select(10)->slack_webhook->value());
|
||||
$webhook = $slack->get_internal_department_goal_progress_webhook_url();
|
||||
if ($webhook !== '') {
|
||||
$slack->send_webhook_message($tmp, $webhook);
|
||||
}
|
||||
}
|
||||
// Send a department-specific message for each internal department with the percentage of addons sold
|
||||
foreach ( $department_ids as $department_id ) {
|
||||
|
||||
Reference in New Issue
Block a user