From 4430345831ac8efecd27977f2758fbbb8d7d5f49 Mon Sep 17 00:00:00 2001
From: Jeppe B <2jepp9350@gmail.com>
Date: Sun, 16 Aug 2026 13:05:25 +0200
Subject: [PATCH] fix(api): log new order id when POST /orders succeeds (#374)

Merges api PR #374.
---
 services/nginx/app/routes/ordersRoute.php       |  2 +-
 .../OrdersAddRouteCreateLogWiringTest.php       | 17 +++++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 services/nginx/app/tests/Unit/Orders/OrdersAddRouteCreateLogWiringTest.php

diff --git a/services/nginx/app/routes/ordersRoute.php b/services/nginx/app/routes/ordersRoute.php
index 584e91ac..64717a7c 100644
--- a/services/nginx/app/routes/ordersRoute.php
+++ b/services/nginx/app/routes/ordersRoute.php
@@ -237,7 +237,7 @@ class ordersRoute
                     $order->setPendingHandheldIndicator();
                 }
                 // Log the incident
-                (new logs_o())->add('orders', $data['department_id'], 1, $user->id, 'ADD_ORDER', 'Successfully added an order (ID: ' . $data['department_id'] . ')');
+                (new logs_o())->add('orders', $data['department_id'], 1, $user->id, 'ADD_ORDER', 'Successfully added an order (ID: ' . (int)$order->id . ')');
                 // Return a success message, containing the orders array
                 $response->success($order->asArray());
             } else { 
diff --git a/services/nginx/app/tests/Unit/Orders/OrdersAddRouteCreateLogWiringTest.php b/services/nginx/app/tests/Unit/Orders/OrdersAddRouteCreateLogWiringTest.php
new file mode 100644
index 00000000..d91ac4fd
--- /dev/null
+++ b/services/nginx/app/tests/Unit/Orders/OrdersAddRouteCreateLogWiringTest.php
@@ -0,0 +1,17 @@
+<?php
+
+it('logs the newly created order id (not the department id) when POST /orders succeeds', function (): void {
+    $routeFile = app_path('routes/ordersRoute.php');
+    $content = file_get_contents($routeFile);
+
+    expect($content)->not->toBeFalse();
+
+    // The POST /orders handler must log the id of the order that was just
+    // persisted by addArray(), not the department id from the request body.
+    // Without this, the audit trail for the "check-in creates 0-orders" bug
+    // is useless — every successful create logs the wrong identifier.
+    expect($content)->toContain("'Successfully added an order (ID: ' . (int)\$order->id . ')'");
+
+    // Guard against the previous copy/paste regression reappearing.
+    expect($content)->not->toContain("'Successfully added an order (ID: ' . \$data['department_id'] . ')'");
+});