copenhagentruckwash/api
1
0
Fork 0
Code Issues Pull Requests 1 Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #231 from copenhagentruckwash/fix-exposure-of-private-git-commit-metadata

Browse Source 
Redact GitHub commit metadata from public release runtime
This commit is contained in:
Jeppe B
2026-06-01 23:25:38 +02:00
committed by GitHub
parent 20d6056e40 5e8ec85943
commit 4f9a10402b
2 changed files with 34 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/nginx/app/tests/Unit/ReleaseManager/ReleaseManagerTest.php
+12 -3
View File
@@ -1357,7 +1357,7 @@ it('resolves release deployment endpoints from manual overrides, URLs, health ch
]))->toBe('https://gateway.example.test/beta/frontend');
});
it('exposes release version git commit metadata for runtime channel cards', function (): void {
it('redacts GitHub access metadata from public release versions', function (): void {
$manager = new release_manager();
$publicVersion = new ReflectionMethod(release_manager::class, 'publicVersion');
$publicVersion->setAccessible(true);
@@ -1375,20 +1375,29 @@ it('exposes release version git commit metadata for runtime channel cards', func
'deployed_url' => null,
'status' => 'active',
'metadata_json' => json_encode([
'commit_mode' => 'specific',
'github_access' => [
'commit' => [
'sha' => 'c0ffee0000001111222233334444555566667777',
'message' => 'Private implementation detail',
'author_name' => 'Release Bot',
'authored_at' => '2026-05-19T10:15:00Z',
],
'commit_authored_at' => '2026-05-19T10:15:00Z',
],
'bundle_member' => true,
]),
'created_at' => '2026-05-19 10:10:00',
'deployed_at' => '2026-05-19 10:20:00',
]);
expect($version['commit_sha'])->toBe('c0ffee0000001111222233334444555566667777');
expect($version['commit']['sha'])->toBe('c0ffee0000001111222233334444555566667777');
expect($version['commit_authored_at'])->toBe('2026-05-19T10:15:00Z');
expect($version['commit'])->toBeNull();
expect($version['commit_authored_at'])->toBeNull();
expect($version['metadata'])->toBe([
'commit_mode' => 'specific',
'bundle_member' => true,
]);
expect($version['deployed_at'])->toBe('2026-05-19 10:20:00');
});