Handle prepared statement failure with error response in DELETE /order/items

2026-07-06 23:16:55 +00:00
parent d0f94ac549
commit 734cd13c87
1 changed files with 7 additions and 7 deletions
@@ -190,14 +190,14 @@ class orderItemsRoute
                // Look up the order item to check department access
                $itemId = (int)$data['id'];
                $stmt = $db->prepare('SELECT oi.order_id FROM order_items oi WHERE oi.id = ? LIMIT 1');
-                if ($stmt !== false) {
+                if ($stmt === false) {
+                    (new logs_o())->add('order_items', 'global', 1, 0, 'DELETE_ORDER_ITEMS', 'Failed to prepare department access check query');
+                    $response->error('Failed to validate department access', 500);
+                }
                $stmt->bind_param('i', $itemId);
                $stmt->execute();
                $orderItemRow = $stmt->get_result()->fetch_assoc();
                $stmt->close();
-                } else {
-                    $orderItemRow = null;
-                }
                if ($orderItemRow !== null) {
                    $orderForAccess = (new orders_o())->getOrderById((int)$orderItemRow['order_id']);
                    if ($orderForAccess->exists()) {