copenhagentruckwash/api
1
0
Fork 0
Code Issues Pull Requests 1 Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #209 from copenhagentruckwash/fix-unauthenticated-certificate-download-vulnerability

Browse Source 
Require authentication token for wash certificate download endpoint
This commit is contained in:
Jeppe B
2026-06-01 22:57:33 +02:00
committed by GitHub
parent 7de4b96074 06421beb6b
commit 7436584598
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/nginx/app/modules/washcertificates/certificates/index.php
+6 -2
View File
@@ -20,7 +20,11 @@ if (!is_numeric($certificate_id) || $certificate_id < 1) {
return; return;
} }
// TODO: Add authentication here // Require a valid static token before serving certificates
if (!isset($_GET['secret_token']) || $_GET['secret_token'] !== $WORDPRESS_STATIC_TOKEN) {
header('HTTP/1.0 401 Unauthorized');
return;
}
// Check if the certificate exists in the /output/certificates folder // Check if the certificate exists in the /output/certificates folder
if (!file_exists("../output/certificates/wash_certificate_" . $certificate_id . ".pdf")) { if (!file_exists("../output/certificates/wash_certificate_" . $certificate_id . ".pdf")) {
@@ -34,4 +38,4 @@ header('Content-Disposition: attachment; filename="wash certificate ' . $certifi
// Output the certificate // Output the certificate
readfile("../output/certificates/wash_certificate_" . $certificate_id . ".pdf"); readfile("../output/certificates/wash_certificate_" . $certificate_id . ".pdf");
exit; exit;