Fix route permission instance calls (#344)
## Root cause `route_t::hasPermission()` and `requirePermission()` are instance methods. Route code was invoking them with `self::`; the new XL Vask hall-scope helper made that call from a genuinely static context, causing PHP to throw: `Non-static method routes\\xlvaskUsageLogsRoute::hasPermission() cannot be called statically` ## Changes - Invoke route permission methods through `$this` across all 273 executable legacy calls in 45 route classes. - Make `xlvaskUsageLogsRoute::allowedHallIdsForUser()` an instance helper and update all 13 callers. - Preserve the existing all-scope and own-scope hall selection rules. - Add a token-aware regression test that rejects executable `self::hasPermission()` and `self::requirePermission()` calls, while ignoring comments. - Add focused XL Vask tests for global scanner hall scope and group-limited own scope. - Update affected route contract assertions to the instance-call form. ## Verification - PHP lint: all 53 changed PHP files - Focused PHPStan: changed XL Vask route and both new regression tests — clean - Focused regression slice: 58 passed, 748 assertions - Full local unit suite: 1,300 passed, 9,442 assertions (1 unrelated existing warning, 1 environment skip) - Full local API suite: 285 passed, 11,704 assertions - Exact-SHA GitHub Tests workflow: all 7 jobs passed (unit, API, integration, legacy, edge gateway, and supporting checks) - Independent exact-SHA QA gate: PASS, no findings - Independent exact-SHA security gate: PASS, no findings - Independent exact-SHA reviewer gate: PASS, no findings - Remote comparison: exactly one commit ahead of `40b104abed7723a7d1b7028190ecda0e7aeef829`; all 53 remote blob hashes matched the reviewed worktree ## Delivery state Draft only for human review. No merge or deployment is included. Qodana is skipped while the PR remains draft and is therefore not represented as a passed gate.
This commit is contained in:
@@ -16,9 +16,9 @@ class potentialOrderMatchesRoute
|
||||
$this->get('/orders/sync/potential-matches', function () {
|
||||
// Require the user to be logged in
|
||||
global $response;
|
||||
self::requirePermission('list_potential_order_matches');
|
||||
$this->requirePermission('list_potential_order_matches');
|
||||
// Check if the user has permission to list all potential order matches
|
||||
if (self::hasPermission('list_all_potential_order_matches')) {
|
||||
if ($this->hasPermission('list_all_potential_order_matches')) {
|
||||
$this->requirePermission('list_all_potential_order_matches');
|
||||
} else {
|
||||
$this->requirePermission('list_own_potential_order_matches');
|
||||
@@ -85,7 +85,7 @@ class potentialOrderMatchesRoute
|
||||
$this->post('/orders/sync/potential-matches/ignore-duplicate', function () {
|
||||
// Require the user to be logged in
|
||||
global $response;
|
||||
self::requirePermission('ignore_duplicate_potential_order_matches');
|
||||
$this->requirePermission('ignore_duplicate_potential_order_matches');
|
||||
// Get the user object
|
||||
$user = (new authentication())->get_user();
|
||||
// Check if the request was successful
|
||||
|
||||
Reference in New Issue
Block a user