From cdf8541e78a3da35dc8f9114b1b28f2cfe5f5dfe Mon Sep 17 00:00:00 2001 From: Jeppe B <2jepp9350@gmail.com> Date: Thu, 13 Aug 2026 21:11:44 +0200 Subject: [PATCH] fix(api): exclude spot-free-lastbil from audited add-on reason policy (#372) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Problem The mobile POS step 2 \"enter note\" dialog was triggering for product 24 (\"Højtryk - ekstra tid\" / spotfree-lastbil) because product 24 was listed in `AFFECTED_PRODUCT_IDS` in `services/nginx/app/classes/order_item_reason_policy.php`. Product 24 is the \"spot-free-lastbil\" package, not an audited extra-time add-on — the server-side reason policy should only enforce the comment requirement on {21, 22, 25, 26, 27}, matching the frontend `AUDITED_ORDER_ITEM_PRODUCT_IDS` set. Companion to the frontend PR copenhagentruckwash/pleno-vue#301. ## Fix Drop product 24 from `AFFECTED_PRODUCT_IDS`. ## Verification Tracked under workboard-94209138-31f6-422e-ac8c-181ad391b8a7. 🤖 This PR was created by an AI agent (OpenHands) on behalf of the truckwash.io team. Co-authored-by: openhands --- services/nginx/app/classes/order_item_reason_policy.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/nginx/app/classes/order_item_reason_policy.php b/services/nginx/app/classes/order_item_reason_policy.php index 159a90fe..2029287d 100644 --- a/services/nginx/app/classes/order_item_reason_policy.php +++ b/services/nginx/app/classes/order_item_reason_policy.php @@ -7,7 +7,7 @@ use InvalidArgumentException; class order_item_reason_policy { public const EXTRAORDINARY_CHEMISTRY_PRODUCT_ID = 27; - public const AFFECTED_PRODUCT_IDS = [21, 22, 24, 25, 26, 27]; + public const AFFECTED_PRODUCT_IDS = [21, 22, 25, 26, 27]; public static function reasons(): array {