Optimize product retrieval by department categories and improve filtering in productsRoute

- Refactored `getAllProductInDepartmentCategories` in `departments_o` using `array_reduce` for cleaner and more efficient category loop.
- Enhanced `productsRoute` to filter department-specific products using IDs for stricter matching.
This commit is contained in:
Jeppe Bundgaard
2025-11-17 14:17:05 +01:00
parent 2d121c67cd
commit dfeffed63f
2 changed files with 17 additions and 14 deletions
+8 -13
View File
@@ -382,26 +382,21 @@ class departments_o extends db
}
/**
* @throws Exception
* @return products_o[] An array of all products in the department's categories
* @throws Exception
*/
public function getAllProductInDepartmentCategories(): array
{
self::requireSelected();
// Get all the categories associated
$department_categories = (new department_categories_o())->getDepartmentCategoryObjects($this->id);
$categories = [];
/** @var products_o[] $products */
$products = [];
foreach ( $department_categories as $department_category ) {
$categories[] = $department_category->getCategory();
}
foreach ( $categories as $category ) {
$cat_products = $category->getProducts();
foreach ($cat_products as $cat_product) {
$products[] = $cat_product;
}
}
// Use array_reduce to combine both loops into a single operation
$products = array_reduce($department_categories, function ($products, $department_category) {
return array_merge($products, $department_category->getCategory()->getProducts());
}, []);
// Remove duplicate products
return array_unique($products, SORT_REGULAR);
}