copenhagentruckwash/api
1
0
Fork 0
Code Issues Pull Requests 1 Actions 2 Packages Projects Releases Wiki Activity

Improve DELETE /order/items: clearer error message, 404 when order not found

Browse Source
This commit is contained in:
copilot-swe-agent[bot]
2026-07-06 23:17:50 +00:00
committed by GitHub
parent 734cd13c87
commit e4465d9d91
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/nginx/app/routes/orderItemsRoute.php
+5 -4
View File
@@ -191,8 +191,8 @@ class orderItemsRoute
$itemId = (int)$data['id'];
$stmt = $db->prepare('SELECT oi.order_id FROM order_items oi WHERE oi.id = ? LIMIT 1');
if ($stmt === false) {
(new logs_o())->add('order_items', 'global', 1, 0, 'DELETE_ORDER_ITEMS', 'Failed to prepare department access check query');
$response->error('Failed to validate department access', 500);
(new logs_o())->add('order_items', 'global', 1, 0, 'DELETE_ORDER_ITEMS', 'Database error while preparing department access check query');
$response->error('Database error while checking department access', 500);
}
$stmt->bind_param('i', $itemId);
$stmt->execute();
@@ -200,9 +200,10 @@ class orderItemsRoute
$stmt->close();
if ($orderItemRow !== null) {
$orderForAccess = (new orders_o())->getOrderById((int)$orderItemRow['order_id']);
if ($orderForAccess->exists()) {
self::requireDepartmentAccess((string)(int)$orderForAccess->department_id->value());
if (!$orderForAccess->exists()) {
$response->error('Order not found', 404);
}
self::requireDepartmentAccess((string)(int)$orderForAccess->department_id->value());
}
// Delete the order item
(new order_items_o())->removeOrderItem((int)$data['id']);