Verify API release commit in gateway gate

This commit is contained in:
Jeppe Bundgaard
2026-06-08 17:48:01 +02:00
parent 327a77edf4
commit ef8d97c821
2 changed files with 45 additions and 0 deletions
@@ -1434,6 +1434,7 @@ class release_manager
];
}
$expectedCommit = self::normalizeCommitSha((string)($gateInput['expected_commit'] ?? ''));
$checked = [];
try {
foreach ($gateInput['api_ping_paths'] as $path) {
@@ -1442,9 +1443,19 @@ class release_manager
if (array_key_exists('success', $payload) && $payload['success'] !== true) {
throw new RuntimeException(sprintf('%s returned success=false.', $path));
}
$actualCommit = $this->releaseGateApiPayloadCommitSha($payload);
if ($expectedCommit !== '' && !$this->releaseGateCommitMatches($actualCommit, $expectedCommit)) {
throw new RuntimeException(sprintf(
'%s returned commit %s, expected %s.',
$path,
$actualCommit !== '' ? $actualCommit : 'unknown',
$expectedCommit
));
}
$checked[] = [
'path' => $path,
'status' => $json['status'],
'commit_sha' => $actualCommit !== '' ? $actualCommit : null,
];
}
} catch (Throwable $throwable) {
@@ -1471,10 +1482,24 @@ class release_manager
'context' => [
'api_base_url' => $apiBaseUrl,
'checked' => $checked,
'expected_commit' => $expectedCommit !== '' ? $expectedCommit : null,
],
];
}
private function releaseGateApiPayloadCommitSha(array $payload): string
{
$data = is_array($payload['data'] ?? null) ? $payload['data'] : $payload;
foreach (['api_commit_sha', 'backend_version', 'commit_sha', 'version'] as $key) {
$commit = self::normalizeCommitSha((string)($data[$key] ?? ''));
if ($commit !== '') {
return $commit;
}
}
return '';
}
private function releaseGateFetchJson(string $baseUrl, string $path): array
{
$result = $this->releaseGateFetch($this->releaseGateJoinUrl($baseUrl, $path));