copenhagentruckwash/api
1
0
Fork 0
Code Issues Pull Requests 1 Actions 2 Packages Projects Releases Wiki Activity

Improve CVR lookup error handling and unify phone number registration error messages

Browse Source
This commit is contained in:
Jeppe Bundgaard
2026-06-11 20:17:48 +02:00
parent 8e0936001d
commit fc87b3a8aa
2 changed files with 68 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/nginx/app/routes/authRoute.php
+28 -5
View File
@@ -416,7 +416,7 @@ class authRoute
if ($matchingEconomicCustomer !== null) {
if ($localUserExists) {
$response->error('Company phone number already registered 01', 400);
$response->error('Company phone number already registered', 400);
}
$this->bootstrapLocalCustomerOrFail($companyPhone);
@@ -441,12 +441,35 @@ class authRoute
}
if ($localUserExists) {
$response->error('Company phone number already registered 02', 400);
$response->error('Company phone number already registered', 400);
}
// Get the CVR company information used for the e-conomic customer payload.
$companyInformation = (new virkdata())->getCompanyInformation($cvr, '', []);
$name = (string)($companyInformation->name ?? '');
$companyInformation = null;
try {
$companyInformation = (new virkdata())->getCompanyInformation((string)$cvr, '', []);
} catch (Exception $exception) {
$this->logRegisterCvrIssue('AUTH_REGISTER_CVR_LOOKUP_FAILED', [
'phase' => 'cvr_lookup',
'cvr' => (string)$cvr,
'requestedCustomerNumber' => $companyPhone,
'message' => $exception->getMessage(),
]);
$response->error('CVR could not be verified. Please check the CVR number and try again.', 400);
return;
}
$name = trim((string)($companyInformation->name ?? ''));
if ($name === '') {
$this->logRegisterCvrIssue('AUTH_REGISTER_CVR_LOOKUP_INVALID_RESPONSE', [
'phase' => 'cvr_lookup',
'cvr' => (string)$cvr,
'requestedCustomerNumber' => $companyPhone,
]);
$response->error('CVR could not be verified. Please check the CVR number and try again.', 400);
return;
}
try {
$result = $economic->createCustomer(
(int)$companyPhone,
@@ -765,7 +788,7 @@ class authRoute
private function localCustomerNumberExists(int $customerNumber): bool
{
$rows = (new users_o())->getFieldsWhere([
'customer_number' => (int)$customerNumber,
'customer_number' => (string)$customerNumber,
], ['id']);
return count($rows) > 0;