Jeppe B
ab6c3ba5b6
## Root cause `route_t::hasPermission()` and `requirePermission()` are instance methods. Route code was invoking them with `self::`; the new XL Vask hall-scope helper made that call from a genuinely static context, causing PHP to throw: `Non-static method routes\\xlvaskUsageLogsRoute::hasPermission() cannot be called statically` ## Changes - Invoke route permission methods through `$this` across all 273 executable legacy calls in 45 route classes. - Make `xlvaskUsageLogsRoute::allowedHallIdsForUser()` an instance helper and update all 13 callers. - Preserve the existing all-scope and own-scope hall selection rules. - Add a token-aware regression test that rejects executable `self::hasPermission()` and `self::requirePermission()` calls, while ignoring comments. - Add focused XL Vask tests for global scanner hall scope and group-limited own scope. - Update affected route contract assertions to the instance-call form. ## Verification - PHP lint: all 53 changed PHP files - Focused PHPStan: changed XL Vask route and both new regression tests — clean - Focused regression slice: 58 passed, 748 assertions - Full local unit suite: 1,300 passed, 9,442 assertions (1 unrelated existing warning, 1 environment skip) - Full local API suite: 285 passed, 11,704 assertions - Exact-SHA GitHub Tests workflow: all 7 jobs passed (unit, API, integration, legacy, edge gateway, and supporting checks) - Independent exact-SHA QA gate: PASS, no findings - Independent exact-SHA security gate: PASS, no findings - Independent exact-SHA reviewer gate: PASS, no findings - Remote comparison: exactly one commit ahead of `40b104abed7723a7d1b7028190ecda0e7aeef829`; all 53 remote blob hashes matched the reviewed worktree ## Delivery state Draft only for human review. No merge or deployment is included. Qodana is skipped while the PR remains draft and is therefore not represented as a passed gate.
64 lines
2.0 KiB
PHP
64 lines
2.0 KiB
PHP
<?php
|
|
|
|
namespace routes;
|
|
|
|
use classes\limble;
|
|
use classes\response;
|
|
use classes\router;
|
|
use classes\slack;
|
|
use limble\helpers\limble_tasks_pagination;
|
|
use limble\helpers\limble_webhook_payload_task;
|
|
use traits\route_t;
|
|
|
|
class moduleLimbleRoute
|
|
{
|
|
use route_t;
|
|
|
|
public function run(): void
|
|
{
|
|
global /** @var response $response */
|
|
/** @var router $router */
|
|
$router, $response;
|
|
$this->post('/modules/limble/webhook/task', function () {
|
|
global $response;
|
|
$slack = new slack();
|
|
$this->requirePermission('modules_limble_webhooks_task');
|
|
// Check if the module is enabled
|
|
$limble = new limble();
|
|
$limble->requireModuleEnabled();
|
|
$limble->requireWebhooksEnabled();
|
|
$payload = json_decode(file_get_contents('php://input'), true);
|
|
if (json_last_error() !== JSON_ERROR_NONE) {
|
|
$response->error('Invalid JSON payload', 400);
|
|
}
|
|
$task = new limble_webhook_payload_task($payload);
|
|
// Response
|
|
$response->success('Debug', 200);
|
|
},
|
|
[
|
|
'modules_limble_webhooks_task' => 'Send Limble Webhook Task (POST)',
|
|
]
|
|
);
|
|
|
|
$this->get('/modules/limble/tasks', function () {
|
|
global $response;
|
|
$slack = new slack();
|
|
$slack->send_message('Limble Tasks Endpoint Triggered', 'Limble Tasks');
|
|
$this->requirePermission('modules_limble_tasks');
|
|
// Check if the module is enabled
|
|
$limble = new limble();
|
|
$limble->requireModuleEnabled();
|
|
$pagination = new limble_tasks_pagination();
|
|
//$pagination->tasks = 2;
|
|
// Get the tasks
|
|
$tasks = $limble->getTasks()->formatTasks($limble->listTasks($pagination));
|
|
// Response
|
|
$response->success($tasks, 200);
|
|
},
|
|
[
|
|
'modules_limble_tasks' => 'Get Limble Tasks (GET)',
|
|
]
|
|
);
|
|
}
|
|
}
|