Jeppe B
ab6c3ba5b6
## Root cause `route_t::hasPermission()` and `requirePermission()` are instance methods. Route code was invoking them with `self::`; the new XL Vask hall-scope helper made that call from a genuinely static context, causing PHP to throw: `Non-static method routes\\xlvaskUsageLogsRoute::hasPermission() cannot be called statically` ## Changes - Invoke route permission methods through `$this` across all 273 executable legacy calls in 45 route classes. - Make `xlvaskUsageLogsRoute::allowedHallIdsForUser()` an instance helper and update all 13 callers. - Preserve the existing all-scope and own-scope hall selection rules. - Add a token-aware regression test that rejects executable `self::hasPermission()` and `self::requirePermission()` calls, while ignoring comments. - Add focused XL Vask tests for global scanner hall scope and group-limited own scope. - Update affected route contract assertions to the instance-call form. ## Verification - PHP lint: all 53 changed PHP files - Focused PHPStan: changed XL Vask route and both new regression tests — clean - Focused regression slice: 58 passed, 748 assertions - Full local unit suite: 1,300 passed, 9,442 assertions (1 unrelated existing warning, 1 environment skip) - Full local API suite: 285 passed, 11,704 assertions - Exact-SHA GitHub Tests workflow: all 7 jobs passed (unit, API, integration, legacy, edge gateway, and supporting checks) - Independent exact-SHA QA gate: PASS, no findings - Independent exact-SHA security gate: PASS, no findings - Independent exact-SHA reviewer gate: PASS, no findings - Remote comparison: exactly one commit ahead of `40b104abed7723a7d1b7028190ecda0e7aeef829`; all 53 remote blob hashes matched the reviewed worktree ## Delivery state Draft only for human review. No merge or deployment is included. Qodana is skipped while the PR remains draft and is therefore not represented as a passed gate.
91 lines
3.7 KiB
PHP
91 lines
3.7 KiB
PHP
<?php
|
|
|
|
namespace routes;
|
|
|
|
use classes\authentication;
|
|
use classes\fxratesapi;
|
|
use classes\response;
|
|
use classes\router;
|
|
use objects\currency_conversion_rates_o;
|
|
use objects\logs_o;
|
|
use traits\route_t;
|
|
|
|
class moduleFxRatesAPIRoute
|
|
{
|
|
use route_t;
|
|
|
|
public function run(): void
|
|
{
|
|
global /** @var response $response */
|
|
/** @var router $router */
|
|
$router, $response;
|
|
|
|
|
|
/** Modules > FXRatesAPI > conversion rate > GET */
|
|
$this->get('/modules/fxratesapi/rate', function () {
|
|
global $response;
|
|
$this->requirePermission('modules_fxratesapi_rate');
|
|
$user = (new authentication())->get_user();
|
|
if ($user) {
|
|
self::requireParameters(['base', 'target']);
|
|
self::requireType('base', self::type_string());
|
|
self::requireType('target', self::type_string());
|
|
self::requireMinLength('base', 3);
|
|
self::requireMaxLength('base', 3);
|
|
self::requireMinLength('target', 3);
|
|
self::requireMaxLength('target', 3);
|
|
(new logs_o())->add('modules_fxratesapi', 'global', 1, $user->id, 'MODULES_FXRATESAPI', 'User accessed the conversion rate');
|
|
$result = (new fxratesapi())->getConversionRate(
|
|
self::getParameter('base'),
|
|
self::getParameter('target'),
|
|
'latest',
|
|
[]
|
|
);
|
|
// Check if the result is an error
|
|
if (!isset($result->success) || !$result->success) {
|
|
(new logs_o())->add('modules_fxratesapi', 'global', 1, $user->id, 'MODULES_FXRATESAPI', 'User accessed the conversion rate and got an error');
|
|
$response->error($result->error, 400);
|
|
}
|
|
// Set the rates
|
|
$currency_conversion_rates = (new currency_conversion_rates_o());
|
|
$currency_conversion_rates->setMany($result->rates);
|
|
// Response
|
|
$response->success($result->rates, 200);
|
|
} else {
|
|
(new logs_o())->add('modules_fxratesapi', 'global', 1, 0, 'MODULES_FXRATESAPI', 'User accessed the conversion rate without being logged in');
|
|
$response->error('Invalid session', 400);
|
|
}
|
|
},
|
|
[
|
|
'modules_fxratesapi_rate' => 'Update conversion rates using the FXRatesAPI',
|
|
]
|
|
);
|
|
|
|
/** Modules > FXRatesAPI > conversion rates > GET */
|
|
$this->get('/modules/fxratesapi/rates', function () {
|
|
global $response;
|
|
$this->requirePermission('modules_fxratesapi_rates');
|
|
$user = (new authentication())->get_user();
|
|
if ($user) {
|
|
(new logs_o())->add('modules_fxratesapi', 'global', 1, $user->id, 'MODULES_FXRATESAPI', 'User accessed the conversion rate');
|
|
$result = (new currency_conversion_rates_o())->listObjects(function ($result) {
|
|
return [
|
|
'id' => (int)$result['id'],
|
|
'currency' => $result['currency'],
|
|
'rate' => (float)$result['rate'],
|
|
];
|
|
});
|
|
// Response
|
|
$response->success($result, 200);
|
|
} else {
|
|
(new logs_o())->add('modules_fxratesapi', 'global', 1, 0, 'MODULES_FXRATESAPI', 'User accessed the conversion rate without being logged in');
|
|
$response->error('Invalid session', 400);
|
|
}
|
|
},
|
|
[
|
|
'modules_fxratesapi_rate' => 'Update conversion rates using the FXRatesAPI',
|
|
]
|
|
);
|
|
|
|
}
|
|
} |