MiniMax M3 Subagent
8972b8f2ae
Bug #11: For customer 35131752 ('kd'), the 15% e-conomic discount was configured on the customer but never applied to the draft invoice line items. The customer discount was only used in the flag/preview service for expected price calculations, not when actually building the draft invoice. Changes: - economicCustomers.php: log swallowed missing-currency-price errors so silently-missing discounts (like customer 35131752) become visible in the application log instead of vanishing. - economic_invoice_draft.php: thread the customer discount percentage through addOrderItemLines/addOrderItemLine and apply it at the line level (e-conomic's draft invoice line API requires per-line discountPercentage; an aggregate TotDiscount line is ignored when the customer has a per-line discount configured). - economic_invoices_draft_endpoint.php: forward the customer discount percentage to the draft builder. - collected_order_invoices_o.php: resolve the customer discount via Redis cache + e-conomicCustomers, then pass it to add_orders. - Tests: new EconomicInvoiceDraftCustomerDiscountTest covering the customer 35131752 15% case, plus updates to the existing wiring tests to account for the new parameter and the customer-discount guard on the aggregate TotDiscount line.
69 lines
3.5 KiB
PHP
69 lines
3.5 KiB
PHP
<?php
|
|
|
|
it('routes collected invoice draft line uploads through the multi-order batch endpoint', function (): void {
|
|
$content = file_get_contents(dirname(__DIR__, 3) . '/objects/collected_order_invoices_o.php');
|
|
|
|
expect($content)->not->toBeFalse();
|
|
$content = (string)$content;
|
|
|
|
$start = strpos($content, 'public function addInvoicesToDraft');
|
|
$end = strpos($content, 'public function getLastEconomicTransferMetrics');
|
|
expect($start)->not->toBeFalse();
|
|
expect($end)->not->toBeFalse();
|
|
expect($end)->toBeGreaterThan($start);
|
|
|
|
$methodBlock = substr($content, (int)$start, (int)$end - (int)$start);
|
|
expect($methodBlock)->toContain('$order_objects = [];')
|
|
// Bug #11 customer 35131752 — the customer discount is threaded through add_orders
|
|
// so the line-level discountPercentage is applied to each line item.
|
|
->and($methodBlock)->toContain('$customer_discount_percentage = self::resolveCustomerDiscountPercentageForDraft')
|
|
->and($methodBlock)->toContain('$metrics = (new economic())->invoices->draft->add_orders(')
|
|
->and($methodBlock)->toContain('$customer_discount_percentage')
|
|
->and($methodBlock)->toContain('...$metrics')
|
|
->and($methodBlock)->not->toContain('self::addInvoiceToDraft($order[\'id\'], true, $draft_id, $currency);');
|
|
});
|
|
|
|
it('keeps single-order draft uploads as a wrapper around the batch endpoint', function (): void {
|
|
$content = file_get_contents(dirname(__DIR__, 3) . '/modules/economic/endpoints/invoices/draft/economic_invoices_draft_endpoint.php');
|
|
|
|
expect($content)->not->toBeFalse();
|
|
$content = (string)$content;
|
|
|
|
$singleStart = strpos($content, 'public function add_order');
|
|
$singleEnd = strpos($content, 'public function add_orders');
|
|
expect($singleStart)->not->toBeFalse();
|
|
expect($singleEnd)->not->toBeFalse();
|
|
expect($singleEnd)->toBeGreaterThan($singleStart);
|
|
|
|
$singleBlock = substr($content, (int)$singleStart, (int)$singleEnd - (int)$singleStart);
|
|
expect($singleBlock)->toContain('$this->add_orders($invoiceDraftId, [$order], $currency);');
|
|
|
|
$batchBlock = substr($content, (int)$singleEnd);
|
|
expect($batchBlock)->toContain('$draftInvoice->flushLinesInBatches($line_batch_size);')
|
|
->and($batchBlock)->toContain('$draftInvoice->addOrderItemLines($order, $use_itemized_discounts, $customer_discount_percentage);')
|
|
->and($batchBlock)->toContain("'orders_with_invoice_lines' => \$orders_with_invoice_lines");
|
|
});
|
|
|
|
it('selects itemized discount mode for collected invoice batch transfers', function (): void {
|
|
$content = file_get_contents(dirname(__DIR__, 3) . '/objects/collected_order_invoices_o.php');
|
|
|
|
expect($content)->not->toBeFalse();
|
|
$content = (string)$content;
|
|
|
|
expect($content)->toContain('resolveInvoiceLayoutNumber')
|
|
->and($content)->toContain('invoice_discount_layout')
|
|
->and($content)->toContain('hasDiscountedIncludedInvoiceItems')
|
|
->and($content)->toContain('orderItemHasBillableDiscount')
|
|
->and($content)->toContain('$customer_discount_percentage');
|
|
});
|
|
|
|
it('includes collected invoice batch transfer metrics in queue results when available', function (): void {
|
|
$content = file_get_contents(dirname(__DIR__, 3) . '/classes/economic_transfer_executor.php');
|
|
|
|
expect($content)->not->toBeFalse();
|
|
$content = (string)$content;
|
|
|
|
expect($content)->toContain('$transfer_metrics = $collected_order_invoices->getLastEconomicTransferMetrics();')
|
|
->and($content)->toContain("\$result['economic_transfer_metrics'] = \$transfer_metrics;");
|
|
});
|