Files
api/services/nginx/app/tests/Unit/Selfserve/SelfserveLaneStartEntranceTimeoutTest.php
T
Jeppe Bundgaard 4dd00cd7a2 Add tests for handling ambiguous timeout errors and deferred relay side effects in Self-serve entrance start logic
- Introduced `SelfserveLaneStartEntranceTimeoutHarness` class and supporting tests to validate ambiguous relay timeout handling during entrance operations.
- Added `defer_relay_side_effects` parameter to `selfserve_lane_command_arguments` for improved relay control during wash start.
- Enhanced lane start routine to support conditional relay side effects and timeout handling with detailed logging.
2026-04-28 17:10:04 +02:00

118 lines
3.9 KiB
PHP

<?php
app_require('modules/selfserve/traits/selfserve_lane_command_t.php');
app_require('modules/selfserve/classes/selfserve_lane_command_arguments.php');
app_require('modules/selfserve/helpers/selfserve_lane_port.php');
app_require('modules/selfserve/helpers/selfserve_lane_state.php');
use modules\selfserve\classes\selfserve_lane_command_arguments;
use modules\selfserve\helpers\selfserve_lane_port;
use modules\selfserve\helpers\selfserve_lane_state;
use modules\selfserve\traits\selfserve_lane_command_t;
class SelfserveLaneStartEntranceTimeoutHarness
{
use selfserve_lane_command_t;
public int $id = 771;
/** @var array<int,selfserve_lane_port> */
public array $openCalls = [];
public ?\Throwable $openThrowable = null;
public ?\Throwable $reportedTimeout = null;
public ?selfserve_lane_state $laneState = null;
public int $cleanerRelayCalls = 0;
public int $machineRelayCalls = 0;
public function open(selfserve_lane_port $port, ?int $toggle_after_seconds = null): bool
{
unset($toggle_after_seconds);
$this->openCalls[] = $port;
if ($this->openThrowable !== null) {
throw $this->openThrowable;
}
return true;
}
public function setLaneState(selfserve_lane_state $state): void
{
$this->laneState = $state;
}
protected function reportWashStartEntranceTimeout(\Throwable $e): void
{
$this->reportedTimeout = $e;
}
protected function turnOnCleanerRelayForWashStart(): void
{
$this->cleanerRelayCalls++;
}
protected function setMachineRelayStatusForWashStart(): void
{
$this->machineRelayCalls++;
}
public function runEntranceOpenForStart(): void
{
$this->openEntrancePortForWashStart();
}
public function runStartRelaySideEffects(bool $defer): void
{
$arguments = (new selfserve_lane_command_arguments())->setDeferRelaySideEffects($defer);
$this->runRelaySideEffectsForWashStart($arguments);
}
}
it('continues start when entrance relay dispatch times out ambiguously', function (): void {
$lane = new SelfserveLaneStartEntranceTimeoutHarness();
$timeout = new \RuntimeException('Edge gateway command timed out');
$lane->openThrowable = $timeout;
$lane->runEntranceOpenForStart();
expect($lane->openCalls)->toBe([selfserve_lane_port::ENTRANCE]);
expect($lane->reportedTimeout)->toBe($timeout);
});
it('still fails start for non-timeout entrance relay errors', function (): void {
$lane = new SelfserveLaneStartEntranceTimeoutHarness();
$lane->openThrowable = new \RuntimeException('Invalid relay ID for port ENTRANCE');
expect(fn() => $lane->runEntranceOpenForStart())
->toThrow(\RuntimeException::class, 'Invalid relay ID');
expect($lane->reportedTimeout)->toBeNull();
});
it('parses deferred relay side effects on start command arguments', function (): void {
$arguments = (new selfserve_lane_command_arguments())->setParameters([
'license_plate' => 'ab12345',
'customer_number' => 12345679,
'defer_relay_side_effects' => true,
]);
expect($arguments->license_plate)->toBe('AB12345');
expect($arguments->customer_number)->toBe(12345679);
expect($arguments->defer_relay_side_effects)->toBeTrue();
});
it('skips cleaner and machine relay side effects when start asks to defer them', function (): void {
$lane = new SelfserveLaneStartEntranceTimeoutHarness();
$lane->runStartRelaySideEffects(true);
expect($lane->cleanerRelayCalls)->toBe(0);
expect($lane->machineRelayCalls)->toBe(0);
});
it('keeps cleaner and machine relay side effects for normal start commands', function (): void {
$lane = new SelfserveLaneStartEntranceTimeoutHarness();
$lane->runStartRelaySideEffects(false);
expect($lane->cleanerRelayCalls)->toBe(1);
expect($lane->machineRelayCalls)->toBe(1);
});