## Summary
`GoalsProgressAlertsCron` only consulted the per-department
`slack_webhook`
field when dispatching to Slack. For internal departments — Taulov and
Taastrup are configured as internal via `Slack >
internal_department_ids`
— those per-department webhooks are intentionally empty, so the cron had
no destination to post to and the daily DHL goal never reached the
internal Slack channel.
The dedicated `internal_department_goal_progress_webhook_url` is the
correct destination for these alerts. This change routes the dispatch
through it when **all** of a goal's departments are internal, with a
clean fallback to the existing per-department webhook loop when the
dedicated URL is empty or when the goal includes any non-internal
department. Operator-facing echo lines were added so the cron log
shows exactly which webhook was used for each goal.
## Why "in progress since 21/7"
The legacy cron flow is intact, the new cron-worker is wired up, and
the schedule fires every 60 s as expected. The goal records the right
department IDs. The destination check in the dispatcher silently
matched nothing — the per-department webhook was empty, the fallback to
the default webhook pointed to the wrong channel, and nothing in the
log indicated *which* dispatch path had been taken. Switching the
internal-department branch to the dedicated goal-progress webhook is
the real fix; the diagnostic echo lines prevent this from being silent
in the future.
## Changes
- `services/nginx/app/cron/Cron.php` (GoalsProgressAlertsCron SLACK
branch): when all linked departments are flagged as internal and the
dedicated `internal_department_goal_progress_webhook_url` is
configured, post to that webhook instead of the per-department
webhooks. Otherwise behave exactly as before.
-
`services/nginx/app/tests/Unit/Cron/GoalsProgressAlertsInternalWebhookTest.php`:
pin the new dispatch behaviour with four targeted tests covering
the happy path, the empty-webhook fallback, the mixed/external
goal path, and the Slack config helper calls.
## Test plan
- `vendor/bin/pest
tests/Unit/Cron/GoalsProgressAlertsInternalWebhookTest.php`
→ 4 passed, 18 assertions.
- `vendor/bin/pest tests/Unit/Cron/` → 34 passed (full cron suite
still green).
- Manual: after deploy, force-run the task via the existing
`POST /api/superuser/cron/run` endpoint with body
`{"job": "goals.progress_alerts"}` and confirm the
`[CRON] GoalsProgressAlertsCron: goal #N sent to internal goal
progress webhook (departments: …)` line appears in the cron log and
the message lands in the configured internal Slack channel.
Fixes TRU-76 (DRIFT 15).
Co-authored-by: backend-subagent <backend@truck-wash.local>
