From feeef463540ce6b14c8924dfe51d775ec320e6fa Mon Sep 17 00:00:00 2001 From: Jeppe B <2jepp9350@gmail.com> Date: Mon, 1 Jun 2026 21:07:23 +0200 Subject: [PATCH] Bind frontend release gate to build id --- .github/workflows/release.yml | 3 ++- scripts/release/verify-upload.mjs | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2501549d..405bb606 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -23,6 +23,7 @@ jobs: PLAYWRIGHT_RELEASE_API_BASE_URL: https://api-v2.truckwash.io PLAYWRIGHT_RELEASE_API_PING_PATHS: /ping,/master/api/ping,/canary/api/ping,/stable/api/ping RELEASE_BUILD_ID: ${{ github.run_id }}-${{ github.run_attempt }} + RELEASE_EXPECTED_BUILD_ID: ${{ github.run_id }}-${{ github.run_attempt }} RELEASE_EXPECTED_COMMIT: ${{ github.sha }} RELEASE_WAIT_INITIAL_SECONDS: 45 RELEASE_WAIT_TIMEOUT_SECONDS: 600 @@ -98,7 +99,7 @@ jobs: -X POST "$RELEASE_MANAGER_GATE_URL" \ -H "Authorization: Bearer $RELEASE_MANAGER_GATE_TOKEN" \ -H "Content-Type: application/json" \ - --data "{\"environment_url\":\"$RELEASE_BASE_URL\",\"channel_slug\":\"stable\",\"app\":\"frontend\",\"repository\":\"$RELEASE_REPOSITORY\",\"branch\":\"$RELEASE_BRANCH\",\"expected_commit\":\"$RELEASE_EXPECTED_COMMIT\",\"workflow_url\":\"$RELEASE_WORKFLOW_URL\",\"auto_sync\":true,\"wait_timeout_seconds\":300,\"poll_interval_seconds\":10,\"required_checks\":[\"static_artifact\",\"api_gateway\"]}" + --data "{\"environment_url\":\"$RELEASE_BASE_URL\",\"channel_slug\":\"stable\",\"app\":\"frontend\",\"repository\":\"$RELEASE_REPOSITORY\",\"branch\":\"$RELEASE_BRANCH\",\"expected_commit\":\"$RELEASE_EXPECTED_COMMIT\",\"build_id\":\"$RELEASE_EXPECTED_BUILD_ID\",\"workflow_url\":\"$RELEASE_WORKFLOW_URL\",\"auto_sync\":true,\"wait_timeout_seconds\":300,\"poll_interval_seconds\":10,\"required_checks\":[\"static_artifact\",\"api_gateway\"]}" env: RELEASE_MANAGER_GATE_URL: ${{ secrets.RELEASE_MANAGER_GATE_URL || 'https://api.truckwash.io/release/gate/test-runs' }} RELEASE_MANAGER_GATE_TOKEN: ${{ secrets.RELEASE_MANAGER_GATE_TOKEN }} diff --git a/scripts/release/verify-upload.mjs b/scripts/release/verify-upload.mjs index f172d9fe..3a2b25ae 100644 --- a/scripts/release/verify-upload.mjs +++ b/scripts/release/verify-upload.mjs @@ -120,7 +120,7 @@ async function verifyShell(baseUrl, shellPath) { async function verifyRelease(baseUrl) { const expectedCommit = process.env.RELEASE_EXPECTED_COMMIT || process.env.GITHUB_SHA || ""; - const expectedBuildId = process.env.RELEASE_EXPECTED_BUILD_ID || ""; + const expectedBuildId = process.env.RELEASE_EXPECTED_BUILD_ID || process.env.RELEASE_BUILD_ID || ""; const manifest = await fetchJson(baseUrl, "release-manifest.json"); const releaseEntry = await fetchJson(baseUrl, "release-entry.json");