copenhagentruckwash/api
1
0
Fork 0
Code Issues Pull Requests 1 Actions 2 Packages Projects Releases Wiki Activity

Prevent XL Vask list automation execution

Browse Source
This commit is contained in:
Jeppe B
2026-06-01 20:54:44 +02:00
parent 70080086da
commit a466c6291c
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/nginx/app/routes/xlvaskUsageLogsRoute.php
+1 -1
View File
@@ -67,7 +67,7 @@ class xlvaskUsageLogsRoute
->setAdditionalWhereClause("`Customer` NOT IN ('" . implode("', '", $xlvask_usage_log::$default_customers) . "')")
->listObjectsWithPaginationIfSet(
function ($log) use ($response_includes_items_link, $response_includes_items, $xlvask_usage_logs, $user, $xlvask, $automation_service, &$linked_order_ids_by_wash_id) {
$automation = $automation_service->evaluateUsageLogRow($log, (int)$user->id, true);
$automation = $automation_service->evaluateUsageLogRow($log, (int)$user->id, false);
// Remove the 'id' field from the log
$id = (int)$log['id'];
unset($log['id']);
services/nginx/app/tests/Unit/XLVask/XLVaskUsageRouteContractTest.php
+13
View File
@@ -14,3 +14,16 @@ it('exposes direct linked order metadata on XL Vask usage order rows', function
->and($route)->toContain("'linked_order_id' => \$linked_order_id")
->and($route)->toContain("'usage_log_id' => \$id");
});
it('does not execute XL Vask usage automation while listing usage order rows', function (): void {
$route = file_get_contents(WD . '/routes/xlvaskUsageLogsRoute.php');
expect($route)->not->toBeFalse();
$route = (string)$route;
expect($route)
->toContain('$automation = $automation_service->evaluateUsageLogRow($log, (int)$user->id, false);')
->and($route)->not->toContain('$automation = $automation_service->evaluateUsageLogRow($log, (int)$user->id, true);')
->and($route)->toContain("requirePermission('manage_xlvask_usage_automation')");
});