copenhagentruckwash/api
1
0
Fork 0
Code Issues Pull Requests 1 Actions 2 Packages Projects Releases Wiki Activity

Simplify count method by inlining variable assignments in goals_criteria_products.

Browse Source
This commit is contained in:
Jeppe Bundgaard
2026-01-26 16:09:09 +01:00
parent 4bfda5aea4
commit f94efa7c59
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/nginx/app/modules/goals/classes/goals_criteria_products.php
+5 -10
View File
@@ -18,17 +18,12 @@ class goals_criteria_products implements goals_criteria_products_i
public function count(goals_criteria $goal): int
{
$count = 0;
$product_ids = $this->listIDs();
$department_ids = $goal->departments->listIDs();
$customer_numbers = $goal->users->listCustomerNumbers();
$datetime_start = $goal->start;
$datetime_end = $goal->end;
$items = order_items_o::getListByCriteria(
department_ids: $department_ids,
product_ids: $product_ids,
customer_numbers: $customer_numbers,
datetime_start: $datetime_start,
datetime_end: $datetime_end,
department_ids: $goal->departments->listIDs(),
product_ids: $this->listIDs(),
customer_numbers: $goal->users->listCustomerNumbers(),
datetime_start: $goal->start,
datetime_end: $goal->end,
);
foreach ($items as $item) {
$count += $item->quantity;