Fix Qodana workflow and Windows-style test gateway paths

Update the Qodana workflow to use an available action version and avoid cloud-token failures when the secret is absent. Keep the test gateway path resolver using Windows path semantics for Windows-style inputs.
Support Windows-style test gateway paths
2026-05-28 19:33:02 +02:00 · 2026-05-28 19:16:52 +02:00 · 2026-05-28 19:11:58 +02:00 · 2026-05-28 19:00:31 +02:00
2 changed files with 34 additions and 4 deletions
@@ -24,10 +24,28 @@ jobs:
        run: |
          mkdir -p "${RUNNER_TEMP}/qodana/caches"
          mkdir -p "${RUNNER_TEMP}/qodana/results"
+      - name: Detect Qodana Cloud token
+        id: qodana-token
+        env:
+          QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
+        run: |
+          if [ -n "${QODANA_TOKEN:-}" ]; then
+            echo "present=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "present=false" >> "$GITHUB_OUTPUT"
+          fi
+
      - name: 'Qodana Scan'
-        uses: JetBrains/qodana-action@v2025.3
+        if: ${{ steps.qodana-token.outputs.present == 'true' }}
+        uses: JetBrains/qodana-action@v2026.1
        with:
          pr-mode: false
        env:
          QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
          QODANA_ENDPOINT: 'https://qodana.cloud'
+
+      - name: 'Qodana Scan (without cloud upload)'
+        if: ${{ steps.qodana-token.outputs.present != 'true' }}
+        uses: JetBrains/qodana-action@v2026.1
+        with:
+          pr-mode: false
@@ -25,6 +25,16 @@ function composeArgs(projectName, args) {
  return ["compose", "-p", projectName, ...args];
 }

+function usesWindowsPathSyntax(filePath) {
+  return /^[A-Za-z]:($|[\\/])/.test(filePath) || filePath.startsWith("\\\\") || filePath.includes("\\");
+}
+
+function pathForInputs(...filePaths) {
+  const hasWindowsPath = filePaths.some((filePath) => usesWindowsPathSyntax(String(filePath || "")));
+
+  return hasWindowsPath ? path.win32 : path;
+}
+
 async function resolveRootDir(scriptPath) {
  const cwd = process.cwd();

@@ -66,7 +76,7 @@ export function resolveComposeProjectName(rootDir, env = process.env) {
    return explicit;
  }

-  return path.basename(rootDir);
+  return pathForInputs(rootDir).basename(rootDir);
 }

 export function resolveComposeNetworkName(rootDir, env = process.env) {
@@ -74,11 +84,13 @@ export function resolveComposeNetworkName(rootDir, env = process.env) {
 }

 export function resolveConfigDirectory(rootDir, explicitDir = null) {
+  const pathModule = pathForInputs(rootDir, explicitDir);
+
  if (explicitDir) {
-    return path.resolve(rootDir, explicitDir);
+    return pathModule.resolve(rootDir, explicitDir);
  }

-  return path.join(rootDir, ".tmp", "test-gateway");
+  return pathModule.join(rootDir, ".tmp", "test-gateway");
 }

 export function shouldClaimGateway(existingConfig = {}, installToken = "") {
Author	SHA1	Message	Date
Jeppe B	aceaa6b957	Fix Qodana workflow and Windows-style test gateway paths Update the Qodana workflow to use an available action version and avoid cloud-token failures when the secret is absent. Keep the test gateway path resolver using Windows path semantics for Windows-style inputs.	2026-05-28 19:33:02 +02:00
Jeppe B	270e5b970f	Support Windows-style test gateway paths Resolve test gateway paths with the Windows path implementation when inputs use Windows-style syntax. This preserves the existing runnable script test suite without adding Windows-only tests.	2026-05-28 19:16:52 +02:00
Jeppe B	5dac3211ff	Fix test gateway Windows config paths ### Motivation - Tests that resolve the test gateway config directory were failing on Windows-style paths because the code always used the POSIX `path` module, producing mismatched separators. - Preserve Windows path semantics when `rootDir` or an explicit config path uses Windows syntax while leaving POSIX behavior unchanged. ### Description - Add `usesWindowsPathSyntax` and `pathForInputs` helpers to detect Windows-style paths and select `path.win32` when needed. - Use the selected `pathModule` in `resolveConfigDirectory` to call `resolve`/`join` so Windows roots or explicit Windows dirs keep correct separators. - Change is confined to `scripts/test-gateway.mjs` and does not alter other runtime behavior. ### Testing - Ran `node --test scripts/*.test.mjs` which initially showed one failing path test and after the fix completed with all tests passing (`14` passed, `0` failed). - Ran `npm test` in `services/edge-agent` and `services/edge-broker`, both suites passed (`18` and `23` tests respectively). - Ran `node scripts/sync-ai-workflow.mjs --check` and `git diff --check` which both succeeded.	2026-05-28 19:11:58 +02:00
Jeppe B	4d91fc8ead	Fix test gateway Windows config paths	2026-05-28 19:00:31 +02:00