## Summary - notify customers by SMS with approve/deny links when a subuser requests access - notify subusers by SMS after approval or denial, including manual grant changes - support subuser password reset and authenticated password changes - add read-only token previews followed by explicit POST confirmation - store short-lived one-time purpose-bound action tokens only as SHA-256 digests - serialize grant decisions transactionally to prevent conflicting concurrent actions - document the API contract in OpenAPI ## Security - generic reset responses reduce account enumeration - URL tokens are removed from browser history after frontend bootstrap - approval previews never mutate state - concurrent decisions lock the exact grant row - SMS failures remain non-fatal and are returned as delivery status Residual risk: existing subuser sessions cannot all be centrally invalidated after password reset because there is no per-subuser session index; they expire normally within the existing session lifetime. ## Verification - backend Pest: 14 tests, 91 assertions - PHP syntax checks passed - focused PHPStan passed - OpenAPI YAML parsed successfully - `git diff --check` passed Database-backed API integration tests were unavailable because the local environment lacks the required database configuration. ## Paired delivery Paired Frontend PR: https://github.com/copenhagentruckwash/pleno-vue/pull/231 Both PRs are required before completion. The frontend PR contains the responsive visual comparisons. Co-authored-by: Jeppe Bundgaard <jb@truckwash.dk>
157 lines
8.9 KiB
PHP
157 lines
8.9 KiB
PHP
<?php
|
|
|
|
it('exposes chauffeur management endpoints on the subusers route', function (): void {
|
|
$routeFile = app_path('routes/subusersRoute.php');
|
|
expect(is_file($routeFile))->toBeTrue();
|
|
|
|
$code = (string)file_get_contents($routeFile);
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain("\$this->post('/subusers/invite', function () {");
|
|
expect($normalized)->toContain("\$this->post('/subusers/invite/resend', function () {");
|
|
expect($normalized)->toContain("\$this->get('/superuser/subusers', function () {");
|
|
expect($normalized)->toContain("\$this->post('/superuser/subusers/invite', function () {");
|
|
expect($normalized)->toContain("\$this->post('/superuser/subusers/invite/resend', function () {");
|
|
expect($normalized)->toContain("\$this->put('/subusers', function () {");
|
|
expect($normalized)->toContain("\$this->put('/subusers/me', function () {");
|
|
expect($normalized)->toContain("\$this->get('/subusers/me/verification', function () {");
|
|
expect($normalized)->toContain("\$this->post('/subusers/me/verification/{channel}/send', function () {");
|
|
expect($normalized)->toContain("\$this->post('/subusers/me/verification/{channel}/verify', function () {");
|
|
expect($normalized)->toContain("\$this->post('/superuser/subusers/{subuser_id}/verification/{channel}/send', function () {");
|
|
expect($normalized)->toContain("\$this->patch('/superuser/subusers/{subuser_id}/verification/{channel}', function () {");
|
|
expect($normalized)->toContain("\$this->post('/superuser/subusers/{subuser_id}/password-guide/{channel}/send', function () {");
|
|
expect($normalized)->toContain("\$this->post('/superuser/subusers/{subuser_id}/login-link/{channel}/send', function () {");
|
|
expect($normalized)->toContain("\$this->post('/subusers/{subuser_id}/verification/{channel}/send', function () {");
|
|
expect($normalized)->toContain("\$this->post('/subusers/password-reset/request', function () {");
|
|
expect($normalized)->toContain("\$this->get('/subusers/password-reset/validate', function () {");
|
|
expect($normalized)->toContain("\$this->post('/subusers/password-reset/set', function () {");
|
|
expect($normalized)->toContain("\$this->post('/subusers/me/password', function () {");
|
|
expect($normalized)->toContain("\$this->get('/subusers/access-decision', function () {");
|
|
expect($normalized)->toContain("\$this->post('/subusers/access-decision', function () {");
|
|
});
|
|
|
|
it('delivers purpose-bound SMS notifications for grant requests and decisions', function (): void {
|
|
$code = (string)file_get_contents(app_path('routes/subusersRoute.php'));
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain('notifyCustomerOfGrantRequest(');
|
|
expect($normalized)->toContain('PURPOSE_GRANT_APPROVE');
|
|
expect($normalized)->toContain('PURPOSE_GRANT_DENY');
|
|
expect($normalized)->toContain('notifySubuserGrantDecision(');
|
|
expect($normalized)->toContain("'decision_notification' => \$delivery");
|
|
expect($normalized)->toContain("'customer_notification' => \$customerNotification");
|
|
});
|
|
|
|
it('keeps forgot-password responses generic and protects reset tokens by purpose', function (): void {
|
|
$code = (string)file_get_contents(app_path('routes/subusersRoute.php'));
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain('Hvis chaufførkontoen findes, er et nulstillingslink sendt.');
|
|
expect($normalized)->toContain('PURPOSE_PASSWORD_RESET');
|
|
expect($normalized)->toContain("account_deletion_service::principalIsBlocked('subuser'");
|
|
expect($normalized)->toContain('invalidateCurrentSetupToken()');
|
|
});
|
|
|
|
it('includes grant management fields in the subusers payload builder', function (): void {
|
|
$routeFile = app_path('routes/subusersRoute.php');
|
|
expect(is_file($routeFile))->toBeTrue();
|
|
|
|
$code = (string)file_get_contents($routeFile);
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain("'grant_id' =>");
|
|
expect($normalized)->toContain("'grant_enabled' =>");
|
|
expect($normalized)->toContain("'grant_note' =>");
|
|
expect($normalized)->toContain("'grant_permissions' =>");
|
|
expect($normalized)->toContain("'setup_required' =>");
|
|
expect($normalized)->toContain("'invite_accepted' =>");
|
|
expect($normalized)->toContain("'can_resend_invite' =>");
|
|
expect($normalized)->toContain("'profile_editable_by_manager' => false");
|
|
expect($normalized)->toContain("'access_state' =>");
|
|
expect($normalized)->toContain("'email_verified' =>");
|
|
expect($normalized)->toContain("'phone_verified' =>");
|
|
expect($normalized)->toContain("'verification_state' =>");
|
|
});
|
|
|
|
it('resolves subuser customer names without external lookups during list requests', function (): void {
|
|
$routeFile = app_path('routes/subusersRoute.php');
|
|
expect(is_file($routeFile))->toBeTrue();
|
|
|
|
$code = (string)file_get_contents($routeFile);
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain('getCustomerNames($customerNumbers, false)');
|
|
expect($normalized)->toContain('$customerName = $this->resolveCustomerName($customerNumber);');
|
|
expect($normalized)->toContain('buildSubuserManagementPayload($subuser, $customerNumber, $customerName)');
|
|
expect($normalized)->not->toContain("'customer_name' => (new users_o())->getCustomerName(\$customerNumber)");
|
|
expect($normalized)->not->toContain("'name' => (new users_o())->getCustomerName((int)\$grant['billing_customer_number'])");
|
|
});
|
|
|
|
it('links grant disable operations to SUBUSERS_DELETE for own-customer managers', function (): void {
|
|
$routeFile = app_path('routes/subusersRoute.php');
|
|
expect(is_file($routeFile))->toBeTrue();
|
|
|
|
$code = (string)file_get_contents($routeFile);
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain("definePermission('delete_own_subusers', subusers_permission_node_key::SUBUSERS_DELETE)");
|
|
expect($normalized)->toContain("requireManagedCustomerScope(subusers_permission_node_key::SUBUSERS_DELETE, \$targetCustomer);");
|
|
});
|
|
|
|
it('parses custom grant writes through raw permissions instead of template expansion', function (): void {
|
|
$routeFile = app_path('routes/subusersRoute.php');
|
|
expect(is_file($routeFile))->toBeTrue();
|
|
|
|
$code = (string)file_get_contents($routeFile);
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain('expandTemplateForWritePayload($templateKey)');
|
|
});
|
|
|
|
it('prevents own-customer managers from editing driver-owned account profiles', function (): void {
|
|
$routeFile = app_path('routes/subusersRoute.php');
|
|
expect(is_file($routeFile))->toBeTrue();
|
|
|
|
$code = (string)file_get_contents($routeFile);
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain("Customers can only manage subuser grants. Drivers own their account profile.");
|
|
});
|
|
|
|
it('scopes superuser invite resend to a selected customer grant', function (): void {
|
|
$routeFile = app_path('routes/subusersRoute.php');
|
|
expect(is_file($routeFile))->toBeTrue();
|
|
|
|
$code = (string)file_get_contents($routeFile);
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain("\$this->post('/superuser/subusers/invite/resend', function () {");
|
|
expect($normalized)->toContain("self::requireParameters(['id', 'customer_number']);");
|
|
expect($normalized)->toContain("\$customerNumber = (int)self::getParameter('customer_number');");
|
|
expect($normalized)->toContain("getGrantForSubuserAndCustomer(\$subuserId, \$customerNumber, true)");
|
|
expect($normalized)->toContain("Subuser grant not found for selected customer");
|
|
expect($normalized)->toContain("'subuser' => \$this->buildSubuserManagementPayload(\$subuser, \$customerNumber)");
|
|
expect($normalized)->toContain("'grant' => \$grant->asArray()");
|
|
});
|
|
|
|
it('only allows invite resend while setup is still pending', function (): void {
|
|
$routeFile = app_path('routes/subusersRoute.php');
|
|
expect(is_file($routeFile))->toBeTrue();
|
|
|
|
$code = (string)file_get_contents($routeFile);
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain("Driver account already accepted the invitation.");
|
|
expect($normalized)->toContain("if (!\$subuser->requiresSetup()) {");
|
|
});
|
|
|
|
it('requires own subuser permissions for classic customer users in managed customer scope', function (): void {
|
|
$routeFile = app_path('routes/subusersRoute.php');
|
|
expect(is_file($routeFile))->toBeTrue();
|
|
|
|
$code = (string)file_get_contents($routeFile);
|
|
$normalized = preg_replace('/\s+/', ' ', $code);
|
|
|
|
expect($normalized)->toContain("\$user = \$auth->get_user(); if (\$user !== false) { \$customerNumber = (int)\$user->customer_number->value(); if (\$customerNumber <= 0) { \$response->error('Unauthorized', 401); } if (\$targetCustomerNumber !== null && \$customerNumber !== (int)\$targetCustomerNumber) { \$this->emitForbidden([\$permission]); } self::requirePermission(\$permission); return \$customerNumber;");
|
|
});
|