Jeppe Bandopenhands 253d72f7fb Fix desktop POS step-2 addon partial sync (mobile + desktop) (#292)
Closes the open POS step-2 bug where only some addons are persisted to
the order. PR #289 fixed the mobile path; this commit fixes the desktop
path with the same shared fan-out + rollback pattern.

## Root cause

Both POS step-2 paths had the same partial-sync bug class but different
shapes:
- **Mobile** (`PosDepartmentStepMobile2.vue → syncMobileOrderItems.js`):
used `Promise.all` over parallel POSTs that short-circuits on first
rejection.
- **Desktop** (`SelectProductsFormPOS.vue →
addAddonsToOrderMiddleware`): used a sequential `await` loop with
`.catch(handleCreateOrderItemError)` that breaks on first failure.

Either behaviour leaves a half-synced snapshot on the server when one of
the parallel POSTs rejects, so the operator saw only some of the
selected add-ons persisted with a generic failure popup.

## Fix

- Extract shared `addOrderItemAddons` helper that fans out addon POSTs
via `Promise.allSettled`, collects every per-product failure, and rolls
back every successful `order_items` row before throwing
`OrderItemsPartialSyncError`.
- Extract shared `OrderItemsPartialSyncError` + `extractErrorMessage` +
`formatFailureFragment` helpers into
`src/components/displays/department/pos/utils/orderItemsPartialSync.js`.
- Wire desktop `SelectProductsFormPOS.vue → addAddonsToOrderMiddleware`
to the shared helper.
- Wire mobile `syncMobileOrderItems.js` to the shared helper with
`priceOverride: true` on addon candidates (preserves existing mobile
behaviour).

## Tests

- New `tests/unit/order-items-addon-fanout.spec.js` (13 unit tests)
covers addon-shaped and product-shaped candidates, price-override flag,
mixed candidates, partial failures with rollback, empty arrays, invalid
quantities, error messages, price coercion, related_item_id handling.
- New e2e test in `tests/e2e/pos-customer-rules.spec.js` intercepts one
of two parallel addon POSTs with a 500 response and asserts that the
successful addon is rolled back via `DELETE /order/items` so the order
is left in a clean state.

## Verification

- Full unit sweep: 1386/1387 pass (only failure: `cpanel-deploy.spec.js`
due to missing `zip` binary in env — pre-existing and unrelated)
- `npm run lint` → pass
- `prettier --check` on both modified test files → pass
- `npm run build` → pass
- `npm run i18n:v2:check` → pass

🤖 This PR was created by an AI agent (OpenHands) on behalf of jepp9350.

Co-authored-by: openhands <openhands@all-hands.dev>

---------

Co-authored-by: openhands <openhands@all-hands.dev>
2026-08-12 23:43:48 +02:00
2026-07-02 11:11:52 +02:00
2026-03-09 10:20:39 +01:00
2026-03-09 10:20:39 +01:00

truckwashdashboardsfrontend

This template should help get you started developing with Vue 3 in Vite.

VSCode + Volar (and disable Vetur).

Customize configuration

See Vite Configuration Reference.

Project Setup

npm install

Contributing Changes

Create a scoped feature branch, push it, and open a pull request targeting master. Do not push directly to master. Merge only after the Required CI check succeeds, all review conversations are resolved, and the branch is up to date. Use squash merge so master retains linear history.

See .github/BRANCH_PROTECTION.md for the repository policy, rollout checks, and emergency bypass procedure.

Compile and Hot-Reload for Development

npm run dev

By default, the Vite dev server proxies /api/* to the remote stable API at https://api-v2.truckwash.io/master/api. This lets the Vue app run locally without a local PHP API container.

To develop against a local PHP API instead:

$env:VITE_API_PROXY_TARGET="http://localhost"; npm run dev

To use another remote API route:

$env:VITE_API_PROXY_BASE_PATH="/canary/api"; npm run dev

TLS certificate validation is enabled for proxied HTTPS APIs by default. If you are using a trusted local HTTPS API with a self-signed certificate, you can opt out explicitly:

$env:VITE_API_PROXY_TARGET="https://local-api.test"; $env:VITE_API_PROXY_SECURE="false"; npm run dev

For compatible local gateways that expect the /api prefix to be preserved:

$env:VITE_API_PROXY_TARGET="http://localhost"; $env:VITE_API_PROXY_STRIP_PREFIX="false"; npm run dev

Compile and Minify for Production

npm run build

Playwright Batched Chromium Runs

Run default e2e tests in deterministic 25-test shards across chromium-desktop and chromium-mobile:

npm run test:e2e:batched:chromium

Run the same flow and automatically re-run failed shards with PLAYWRIGHT_WORKERS=1:

npm run test:e2e:batched:chromium:rerun-failed

Optional overrides:

PLAYWRIGHT_BATCH_SIZE=25
PLAYWRIGHT_BATCH_WORKERS=2
PLAYWRIGHT_BATCH_DEV_PORT=5193

You can also forward Playwright args:

npm run test:e2e:batched:chromium -- --grep @smoke

Artifacts and summaries:

  • output/playwright/batched-chromium/last-run.json
  • output/playwright/batched-chromium/failed-shards.json
  • output/playwright/batched-chromium/report-index.html
  • output/playwright/batched-chromium-shard-<i>-of-<n>/report/index.html
  • output/playwright/batched-chromium-rerun-shard-<i>-of-<n>/report/index.html

Playwright Full E2E

Run the permanent grouped full-suite entrypoint with a hard max of 5 total workers across the browser-engine groups:

  • Chromium
  • WebKit
  • Firefox
npm run test:e2e:ci

The full CI matrix is ordered by browser engine, then device class, then user role:

  • browsers: chromium, webkit, firefox
  • devices: mobile, desktop, tablet
  • roles: superuser, admin, customer, subuser

Run a single full-suite slice for one role and one Playwright project:

npm run test:e2e:full:slice -- --role=admin --project=webkit-tablet

Default worker allocation:

PLAYWRIGHT_PARALLEL_WORKERS_CHROMIUM=2
PLAYWRIGHT_PARALLEL_WORKERS_FIREFOX=1
PLAYWRIGHT_PARALLEL_WORKERS_WEBKIT=1

Optional overrides:

PLAYWRIGHT_PARALLEL_BASE_PORT=5191
PLAYWRIGHT_PARALLEL_WORKERS_CHROMIUM=2
PLAYWRIGHT_PARALLEL_WORKERS_FIREFOX=1
PLAYWRIGHT_PARALLEL_WORKERS_WEBKIT=1

The runner fails fast if the combined worker count exceeds 5.

GitHub Actions keeps the full browser/device/role matrix stable by capping full-suite matrix parallelism at 2 jobs, running each full slice with PLAYWRIGHT_WORKERS=1, wrapping Docker Playwright runs with systemd-inhibit when available, and setting PLAYWRIGHT_VIDEO_MODE=off for the full matrix. The E2E network harness serves Font Awesome from local fixtures so WebKit page loads and visual snapshots do not depend on CDN/TLS availability. Traces and screenshots are still retained on failure.

Artifacts and summaries:

  • output/playwright/ci-parallel-report/index.html
  • output/playwright/ci-parallel-chromium/report/index.html
  • output/playwright/ci-parallel-firefox/report/index.html
  • output/playwright/ci-parallel-webkit/report/index.html
  • output/playwright/test-lists/<project>-<role>.txt
  • output/playwright/test-lists/<role>-<project>.txt (legacy compatibility copy)

Android App Icon

The Play Store Android package is built from the Capacitor project in android/. The legacy Bubblewrap/TWA project at the repository root is not used by npm run mobile:android:bundle.

The native launcher and store icons use the opaque iOS marketing icon as their shared master so Android and iOS keep the same white background:

ios/App/App/Assets.xcassets/AppIcon.appiconset/AppIcon-1024.png

Regenerate the checked-in launcher assets after changing that source image:

npm run mobile:android:icons

Check that the generated Android launcher assets are current:

npm run mobile:android:icons:check

npm run mobile:android:sync runs the icon generator before building and syncing the Capacitor Android project. The generator updates android/app/src/main/res launcher assets, public/icons/icon-192x192.png, public/icons/icon-512x512.png, and store_icon.png.

Mobile Store Releases

Signed Android and iOS store artifacts are built through the GitHub Actions Mobile Store Artifacts workflow. By default, current master after green Automated Tests uploads Android to Google Play production and uploads iOS to App Store Connect.

See docs/mobile-artifacts.md for workflow triggers, required secrets, and local mobile checks. See docs/app-store-release.md for App Store Connect release preparation and review notes. For a separate development-signed IPA that can be installed on an approved iPhone from Ubuntu over USB, see docs/ios-device-debug.md.

Bubblewrap (TWA) Build and Install

To build and install the Trusted Web Activity (TWA) using Bubblewrap, use the following commands:

Build the TWA

bubblewrap build

Install the TWA on a connected device

bubblewrap install
S
Description
Staging repo for pleno-vue (CI + promotion to GitHub)
Readme
146 MiB
Languages
JavaScript 57%
Vue 30.7%
CSS 7%
TypeScript 4.6%
HTML 0.5%