Files
pleno-vue/tests
Jeppe Bandopenhands eb8482585b fix(orders): make reason_comment fallback robust for audited order items (#300)
## Problem

POST /master/api/order/items still returns

> Product 24: Reason comment is required for this product

for products in {21, 22, 24, 25, 26, 27}, even after #296 landed the
mobile POS step 2 note prompt.

The previous `buildAuditedOrderItemReasonPayload` only fell back through
`reason.reason_comment → reason.comment → notes → ''`. Any code path
that
calls `createOrderItem` without populating `notes` (copy-last-wash,
future callers, or even a user who clears the prompt) sent
`reason_comment: ""` and the backend correctly rejected it.

## Fix

* `buildAuditedOrderItemReasonPayload` now uses a `trimmedFirstNonEmpty`
  helper and walks
`reason.reason_comment → reason.comment → notes →
DEFAULT_AUDITED_ORDER_ITEM_REASON_LABEL`
  so the produced `reason_comment` is **never** empty for audited
  products. `reason_code` and `reason_label_snapshot` keep the same
  fallback semantics.
* `createCopiedOrderItem` in `POSDepartmentProcess.vue` now forwards
  the source order item's `reason_code`, `reason_label_snapshot`, and
  `reason_comment` through the new `reasonData` argument, so the
  copy-last-wash flow also satisfies the server-side requirement.

## Tests

`tests/unit/orders-items.spec.js` now covers:

* `createOrderItem` audits products {21,22,24,25,26,27} and emits
  non-empty `reason_comment` even when `notes` is missing
* `reason_comment` falls back to `notes` (trimmed)
* `reason_comment` falls back to the default label when both
  `reasonData` and `notes` are empty / whitespace
* `reasonData` overrides win over `notes`
* non-audited products still don't emit any reason fields
* `AUDITED_ORDER_ITEM_PRODUCT_IDS` membership is locked down

14/14 tests pass locally.

## Production evidence

* Production bundle `Addons-*.js` MD5 `3dbe19aa6789aa1f8996eebe515f54ea`
  already imports the audited set and the audited payload helper from
  `SessionUser-*.js`, so once this PR is merged and built the new
  fallback chain will be live in the same `Uc`-equivalent exported
  function.

🤖 Generated with [OpenHands](https://openhands.dev) on behalf of the
truckwash.io team.

Co-authored-by: openhands <openhands@all-hands.dev>

Co-authored-by: openhands <openhands@all-hands.dev>
2026-08-13 16:40:36 +02:00
..