Jeppe Bandopenhands
eb8482585b
## Problem
POST /master/api/order/items still returns
> Product 24: Reason comment is required for this product
for products in {21, 22, 24, 25, 26, 27}, even after #296 landed the
mobile POS step 2 note prompt.
The previous `buildAuditedOrderItemReasonPayload` only fell back through
`reason.reason_comment → reason.comment → notes → ''`. Any code path
that
calls `createOrderItem` without populating `notes` (copy-last-wash,
future callers, or even a user who clears the prompt) sent
`reason_comment: ""` and the backend correctly rejected it.
## Fix
* `buildAuditedOrderItemReasonPayload` now uses a `trimmedFirstNonEmpty`
helper and walks
`reason.reason_comment → reason.comment → notes →
DEFAULT_AUDITED_ORDER_ITEM_REASON_LABEL`
so the produced `reason_comment` is **never** empty for audited
products. `reason_code` and `reason_label_snapshot` keep the same
fallback semantics.
* `createCopiedOrderItem` in `POSDepartmentProcess.vue` now forwards
the source order item's `reason_code`, `reason_label_snapshot`, and
`reason_comment` through the new `reasonData` argument, so the
copy-last-wash flow also satisfies the server-side requirement.
## Tests
`tests/unit/orders-items.spec.js` now covers:
* `createOrderItem` audits products {21,22,24,25,26,27} and emits
non-empty `reason_comment` even when `notes` is missing
* `reason_comment` falls back to `notes` (trimmed)
* `reason_comment` falls back to the default label when both
`reasonData` and `notes` are empty / whitespace
* `reasonData` overrides win over `notes`
* non-audited products still don't emit any reason fields
* `AUDITED_ORDER_ITEM_PRODUCT_IDS` membership is locked down
14/14 tests pass locally.
## Production evidence
* Production bundle `Addons-*.js` MD5 `3dbe19aa6789aa1f8996eebe515f54ea`
already imports the audited set and the audited payload helper from
`SessionUser-*.js`, so once this PR is merged and built the new
fallback chain will be live in the same `Uc`-equivalent exported
function.
🤖 Generated with [OpenHands](https://openhands.dev) on behalf of the
truckwash.io team.
Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
truckwashdashboardsfrontend
This template should help get you started developing with Vue 3 in Vite.
Recommended IDE Setup
VSCode + Volar (and disable Vetur).
Customize configuration
See Vite Configuration Reference.
Project Setup
npm install
Contributing Changes
Create a scoped feature branch, push it, and open a pull request targeting
master. Do not push directly to master. Merge only after the Required CI
check succeeds, all review conversations are resolved, and the branch is up to
date. Use squash merge so master retains linear history.
See .github/BRANCH_PROTECTION.md for the
repository policy, rollout checks, and emergency bypass procedure.
Compile and Hot-Reload for Development
npm run dev
By default, the Vite dev server proxies /api/* to the remote stable API at
https://api-v2.truckwash.io/master/api. This lets the Vue app run locally
without a local PHP API container.
To develop against a local PHP API instead:
$env:VITE_API_PROXY_TARGET="http://localhost"; npm run dev
To use another remote API route:
$env:VITE_API_PROXY_BASE_PATH="/canary/api"; npm run dev
TLS certificate validation is enabled for proxied HTTPS APIs by default. If you are using a trusted local HTTPS API with a self-signed certificate, you can opt out explicitly:
$env:VITE_API_PROXY_TARGET="https://local-api.test"; $env:VITE_API_PROXY_SECURE="false"; npm run dev
For compatible local gateways that expect the /api prefix to be preserved:
$env:VITE_API_PROXY_TARGET="http://localhost"; $env:VITE_API_PROXY_STRIP_PREFIX="false"; npm run dev
Compile and Minify for Production
npm run build
Playwright Batched Chromium Runs
Run default e2e tests in deterministic 25-test shards across chromium-desktop and chromium-mobile:
npm run test:e2e:batched:chromium
Run the same flow and automatically re-run failed shards with PLAYWRIGHT_WORKERS=1:
npm run test:e2e:batched:chromium:rerun-failed
Optional overrides:
PLAYWRIGHT_BATCH_SIZE=25
PLAYWRIGHT_BATCH_WORKERS=2
PLAYWRIGHT_BATCH_DEV_PORT=5193
You can also forward Playwright args:
npm run test:e2e:batched:chromium -- --grep @smoke
Artifacts and summaries:
output/playwright/batched-chromium/last-run.jsonoutput/playwright/batched-chromium/failed-shards.jsonoutput/playwright/batched-chromium/report-index.htmloutput/playwright/batched-chromium-shard-<i>-of-<n>/report/index.htmloutput/playwright/batched-chromium-rerun-shard-<i>-of-<n>/report/index.html
Playwright Full E2E
Run the permanent grouped full-suite entrypoint with a hard max of 5 total workers across the browser-engine groups:
- Chromium
- WebKit
- Firefox
npm run test:e2e:ci
The full CI matrix is ordered by browser engine, then device class, then user role:
- browsers:
chromium,webkit,firefox - devices:
mobile,desktop,tablet - roles:
superuser,admin,customer,subuser
Run a single full-suite slice for one role and one Playwright project:
npm run test:e2e:full:slice -- --role=admin --project=webkit-tablet
Default worker allocation:
PLAYWRIGHT_PARALLEL_WORKERS_CHROMIUM=2
PLAYWRIGHT_PARALLEL_WORKERS_FIREFOX=1
PLAYWRIGHT_PARALLEL_WORKERS_WEBKIT=1
Optional overrides:
PLAYWRIGHT_PARALLEL_BASE_PORT=5191
PLAYWRIGHT_PARALLEL_WORKERS_CHROMIUM=2
PLAYWRIGHT_PARALLEL_WORKERS_FIREFOX=1
PLAYWRIGHT_PARALLEL_WORKERS_WEBKIT=1
The runner fails fast if the combined worker count exceeds 5.
GitHub Actions keeps the full browser/device/role matrix stable by capping full-suite
matrix parallelism at 2 jobs, running each full slice with PLAYWRIGHT_WORKERS=1,
wrapping Docker Playwright runs with systemd-inhibit when available, and setting
PLAYWRIGHT_VIDEO_MODE=off for the full matrix. The E2E network harness serves
Font Awesome from local fixtures so WebKit page loads and visual snapshots do not
depend on CDN/TLS availability. Traces and screenshots are still retained on
failure.
Artifacts and summaries:
output/playwright/ci-parallel-report/index.htmloutput/playwright/ci-parallel-chromium/report/index.htmloutput/playwright/ci-parallel-firefox/report/index.htmloutput/playwright/ci-parallel-webkit/report/index.htmloutput/playwright/test-lists/<project>-<role>.txtoutput/playwright/test-lists/<role>-<project>.txt(legacy compatibility copy)
Android App Icon
The Play Store Android package is built from the Capacitor project in android/.
The legacy Bubblewrap/TWA project at the repository root is not used by
npm run mobile:android:bundle.
The native launcher and store icons use the opaque iOS marketing icon as their shared master so Android and iOS keep the same white background:
ios/App/App/Assets.xcassets/AppIcon.appiconset/AppIcon-1024.png
Regenerate the checked-in launcher assets after changing that source image:
npm run mobile:android:icons
Check that the generated Android launcher assets are current:
npm run mobile:android:icons:check
npm run mobile:android:sync runs the icon generator before building and syncing
the Capacitor Android project. The generator updates android/app/src/main/res
launcher assets, public/icons/icon-192x192.png, public/icons/icon-512x512.png,
and store_icon.png.
Mobile Store Releases
Signed Android and iOS store artifacts are built through the GitHub Actions
Mobile Store Artifacts workflow. By default, current master after green
Automated Tests uploads Android to Google Play production and uploads iOS to
App Store Connect.
See docs/mobile-artifacts.md for workflow triggers, required secrets, and
local mobile checks. See docs/app-store-release.md for App Store Connect
release preparation and review notes. For a separate development-signed IPA
that can be installed on an approved iPhone from Ubuntu over USB, see
docs/ios-device-debug.md.
Bubblewrap (TWA) Build and Install
To build and install the Trusted Web Activity (TWA) using Bubblewrap, use the following commands:
Build the TWA
bubblewrap build
Install the TWA on a connected device
bubblewrap install